add several ndarray method/properties #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezcano
reviewed
Apr 3, 2023
torch_np/_ndarray.py
Outdated
Comment on lines
408
to
416
| def item(self, *args): | ||
| if args == (): | ||
| return self.tensor.item() | ||
| elif len(args) == 1: | ||
| # int argument | ||
| return self.ravel()[args[0]] | ||
| else: | ||
| return self.__getitem__(args) | ||
|
|
There was a problem hiding this comment.
Do we have tests for this?
There was a problem hiding this comment.
Not at the moment. Don't see numpy tests in numpy proper either. Behavior with arrays seems legacy TBH, so I'd prefer to put it to the priority queue.
There was a problem hiding this comment.
If you pulled this from the NumPy implementation, let's just add a link to it and roll with it.
lezcano
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.